Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

952 upload image icons for talents and capabilities from the catalog #957

Conversation

ywkim312
Copy link
Collaborator

@ywkim312 ywkim312 commented Jun 24, 2022

Description

Uploading icon for capability and talent is added.
The PR is pretty much ready except for the function of getting the access token.
If you want to test the PR, you have to create CORE token manually and put the access token in
contributions/catalog/controllers/contribut.py's line 871.
Just paste your access token in there, and it should be okay for the testing.

Fixes #952

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ywkim312 ywkim312 requested review from minump and sandeep-ps June 30, 2022 19:14
@sandeep-ps sandeep-ps assigned minump and unassigned ywkim312 Jul 7, 2022
@minump
Copy link
Collaborator

minump commented Mar 14, 2023

This PR can be closed as the development process is being moved to Flutter.
Decision made after discussions with the NCSA Rokwire Dev team.

@minump minump closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants